Handle win2019 gcc issue #761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Link: #760 (comment) |
eregon
reviewed
May 1, 2025
| @@ -89,7 +89,7 @@ export async function install(platform, engine, version) { | |||
|
|
|||
| // windows 2016 and 2019 need ucrt64 installed, 2022 and future images need | |||
| // ucrt64 or mingw64 installed, depending on Ruby version | |||
| if (((msys2Type === 'ucrt64') || !hasMSYS2PreInstalled) && common.floatVersion(version) >= 2.4) { | |||
| if ((msys2Type === 'ucrt64') || (common.floatVersion(version) >= 2.4)) { | |||
There was a problem hiding this comment.
So this installs GCC even if MSYS2 is pre-installed, to avoid the too new gcc from the pre-installed MSYS2, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for GCC 15 being preinstalled on win2019