Skip to content

Add jruby-10.0.1.0 #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2025
Merged

Add jruby-10.0.1.0 #781

merged 1 commit into from
Jul 21, 2025

Conversation

ruby-builder-bot
Copy link
Contributor

Automated PR from ruby/ruby-builder

@eregon
Copy link
Member

eregon commented Jul 18, 2025

@headius This is blocked by this failure:
https://github.com/ruby/ruby-builder/actions/runs/16365715458/job/46242352836

Run ruby --version
  ruby --version
  shell: C:\Program Files\PowerShell\7\pwsh.EXE -command ". '{0}'"
  env:
    JAVA_HOME: C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\21.0.7-6.0\x64
    PREFIX: /c/Users/runneradmin/.rubies/jruby-10.0.1.0
'"C:\Users\runneradmin\.rubies\jruby-10.0.1.0\bin\jruby.exe"' is not recognized as an internal or external command,
operable program or batch file.
Error: Process completed with exit code 1.

Note the logic at https://github.com/ruby/ruby-builder/actions/runs/16365715458/job/46242352836#step:10:5

  cd $PREFIX/bin
  # Copy bash launcher, so 'ruby' works in bash
  cp jruby ruby
  # Create ruby.bat, so 'ruby' works in pwsh
  echo -en "@ECHO OFF\r\n@\"%~dp0jruby.exe\" %*\r\n" > ruby.bat

I have tried removing that logic in ruby/ruby-builder@d84df19
but it still gives the same error:
https://github.com/ruby/ruby-builder/actions/runs/16365805938/job/46242634106

Run ruby --version
'"C:\Users\runneradmin\.rubies\jruby-10.0.1.0\bin\jruby.exe"' is not recognized as an internal or external command,
operable program or batch file.

There is apparently no jruby.exe indeed, only jrubyw.exe, is that expected?
https://github.com/ruby/ruby-builder/actions/runs/16365805938/job/46242634106#step:10:1

Run mkdir $(dirname $PREFIX)
total 2031
-rwxr-xr-x 1 runneradmin 197121    5501 Jul 17 00:03 ast
-rw-r--r-- 1 runneradmin 197121      40 Jul 17 00:03 ast.bat
-rwxr-xr-x 1 runneradmin 197121     565 Jul 17 00:03 bundle
-rw-r--r-- 1 runneradmin 197121      43 Jul 17 00:03 bundle.bat
-rwxr-xr-x 1 runneradmin 197121     567 Jul 17 00:03 bundler
-rw-r--r-- 1 runneradmin 197121      44 Jul 17 00:03 bundler.bat
-rwxr-xr-x 1 runneradmin 197121     526 Jul 17 00:03 erb
-rw-r--r-- 1 runneradmin 197121      40 Jul 17 00:03 erb.bat
-rwxr-xr-x 1 runneradmin 197121     123 Jul 17 00:03 gem
-rw-r--r-- 1 runneradmin 197121      40 Jul 17 00:03 gem.bat
-rwxr-xr-x 1 runneradmin 197121     548 Jul 17 00:03 install_doc
-rw-r--r-- 1 runneradmin 197121      48 Jul 17 00:03 install_doc.bat
-rwxr-xr-x 1 runneradmin 197121     526 Jul 17 00:03 irb
-rw-r--r-- 1 runneradmin 197121      40 Jul 17 00:03 irb.bat
-rwxr-xr-x 1 runneradmin 197121     541 Jul 17 00:03 jgem
-rw-r--r-- 1 runneradmin 197121      41 Jul 17 00:03 jgem.bat
-rwxr-xr-x 1 runneradmin 197121     390 Jul 17 00:03 jirb
-rw-r--r-- 1 runneradmin 197121      41 Jul 17 00:03 jirb.bat
-rwxr-xr-x 1 runneradmin 197121    2282 Jul 17 00:03 jirb_swing
-rw-r--r-- 1 runneradmin 197121      47 Jul 17 00:03 jirb_swing.bat
-rwxr-xr-x 1 runneradmin 197121    3731 Jul 17 00:03 jruby
-rw-r--r-- 1 runneradmin 197121     125 Jul 17 00:03 jruby.bat
-rwxr-xr-x 1 runneradmin 197121 1029632 Jul 17 00:03 jruby.dll
-rwxr-xr-x 1 runneradmin 197121   28582 Jul 17 00:03 jruby.sh
-rwxr-xr-x 1 runneradmin 197121     188 Jul 17 00:03 jrubyc
-rw-r--r-- 1 runneradmin 197121      43 Jul 17 00:03 jrubyc.bat
-rw-r--r-- 1 runneradmin 197121     245 Jul 17 00:03 jrubyd.bat
-rwxr-xr-x 1 runneradmin 197121  962048 Jul 17 00:03 jrubyw.exe
-rwxr-xr-x 1 runneradmin 197121     590 Jul 17 00:03 lock_jars
-rw-r--r-- 1 runneradmin 197121      46 Jul 17 00:03 lock_jars.bat
-rwxr-xr-x 1 runneradmin 197121     532 Jul 17 00:03 racc
-rw-r--r-- 1 runneradmin 197121      41 Jul 17 00:03 racc.bat
-rwxr-xr-x 1 runneradmin 197121     532 Jul 17 00:03 rake
-rw-r--r-- 1 runneradmin 197121      41 Jul 17 00:03 rake.bat
-rwxr-xr-x 1 runneradmin 197121     532 Jul 17 00:03 rdoc
-rw-r--r-- 1 runneradmin 197121      41 Jul 17 00:03 rdoc.bat
-rwxr-xr-x 1 runneradmin 197121     528 Jul 17 00:03 ri
-rw-r--r-- 1 runneradmin 197121      39 Jul 17 00:03 ri.bat
-rwxr-xr-x 1 runneradmin 197121    3730 Jul 17 00:03 ruby
-rw-r--r-- 1 runneradmin 197121      31 Jul 17 00:03 ruby.bat
-rwxr-xr-x 1 runneradmin 197121     592 Jul 17 00:03 syntax_suggest
-rw-r--r-- 1 runneradmin 197121      51 Jul 17 00:03 syntax_suggest.bat

Could you figure out what needs to be done here?

@eregon eregon mentioned this pull request Jul 21, 2025
Merged
@headius
Copy link
Contributor

headius commented Jul 21, 2025

I don't think the missing jruby.exe is expected. In the process of cleaning up how we handle the launch scripts, we may have inadvertently removed code that copied that executable into the distribution archive. We noticed a similar problem for bin/jruby and bin/ruby immediately before release but I guess we didn't notice that the exe was also not being shipped.

There's one or two other small regressions that will necessitate a release of 10.0.2.0, so we will fix this in the next week or so.

@headius
Copy link
Contributor

headius commented Jul 21, 2025

And I just saw your comment in ruby/jruby-dev-builder#17 indicating this might actually be a bug in the GitHub runner for Windows and its tar.exe behavior.

@eregon
Copy link
Member

eregon commented Jul 21, 2025

I figured it out, it's another instance of tar in PATH (from Git I think) on Windows which is broken: MSP-Greg#1 (comment) :/

And indeed tar tf lists jruby.exe:
https://github.com/ruby/ruby-builder/actions/runs/16426611932/job/46418343184#step:10:651
But jruby.exe is gone after tar xf:
https://github.com/ruby/ruby-builder/actions/runs/16426611932/job/46418343184#step:10:2771

At least I know how to fix it, sorry for the noise, Windows can be quite the head-scratcher at times...

@headius
Copy link
Contributor

headius commented Jul 21, 2025

@eregon Ok thanks for the extra footwork on this. That's a very peculiar and frustrating bug!

@eregon eregon merged commit a9bfc2e into ruby:master Jul 21, 2025
378 of 380 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ruby-builder-bot @eregon @headius