Skip to content

Add printing of the lockfile after installation (retry) #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 26, 2025
Merged

Add printing of the lockfile after installation (retry) #790

merged 2 commits into from
Jul 26, 2025

Conversation

Fryguy
Copy link
Contributor

@Fryguy Fryguy commented Jul 25, 2025 •
edited
Loading

Reimplementation of #785, but with checking the case of a missing lockfile (caused by a missing Gemfile).

While the case of user bundler-cache: true with a missing Gemfile is strange, it is something that was working prior to #785.

Closes #783

@eregon Please review.

@Fryguy Fryguy changed the title Add printing of the lockfile after installation Add printing of the lockfile after installation (retry) Jul 25, 2025
@Fryguy
Copy link
Contributor Author

Fryguy commented Jul 25, 2025 •
edited
Loading

I verified with the new test case (via nektos/act) that before the code change it exhibited the failures that users were seeing in #787 and #788, and after the changes to check the lockfile exists, that case works: https://github.com/ruby/setup-ruby/actions/runs/16531408828/job/46757430272?pr=790#step:4:32

Before:

| > bundle install
| Could not determine gemfile path, skipping "bundle install" and caching
| Took   0.00 seconds
[Test this action/Test with no Gemfile but with bundler-cache]   ❓  ::group::Print lockfile
| [command]/usr/bin/cat null
| /usr/bin/cat: null: No such file or directory
[Test this action/Test with no Gemfile but with bundler-cache]   ❓  ::endgroup::
[Test this action/Test with no Gemfile but with bundler-cache]   ❗  ::error::The process '/usr/bin/cat' failed with exit code 1
[Test this action/Test with no Gemfile but with bundler-cache]   ❌  Failure - Main ./

After

| > bundle install
| Could not determine gemfile path, skipping "bundle install" and caching
| Took   0.00 seconds
[Test this action/Test with no Gemfile but with bundler-cache]   ✅  Success - Main ./

eregon
eregon reviewed Jul 26, 2025
View reviewed changes
@eregon eregon force-pushed the print_lockfile_deux branch from 0448c6c to 471cc14 Compare July 26, 2025 08:52
eregon
eregon approved these changes Jul 26, 2025
View reviewed changes
Copy link
Member

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@eregon eregon merged commit bb6434c into ruby:master Jul 26, 2025
191 checks passed
@Fryguy Fryguy deleted the print_lockfile_deux branch August 5, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eregon eregon eregon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Print the final content of the Gemfile.lock
2 participants
@Fryguy @eregon