Skip to content

HOST in Rakefile should be a localhost #1977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ismailarilik opened this issue Feb 23, 2019 · 2 comments
Closed

HOST in Rakefile should be a localhost #1977

ismailarilik opened this issue Feb 23, 2019 · 2 comments

Comments

@ismailarilik
Copy link
Member

Hi.

I think HOST variable in Rakefile should be a localhost such as 'localhost:9292'. In development environment we are testing the changes for this environment. Now check:markup task uses 'www.ruby-lang.org' as its host but it is not useful for a local environment. So it should be changed. Checking main site may be done in another environment such as a CI environment.

I don't want to open a PR because I didn't know what is the reason behind this setting. Also I couldn't find any reasonable reason for it in history.

What is your thought about it? Am I wrong about anything?
@spk
Copy link
Contributor

spk commented Mar 4, 2019

Hi,

Thanks for the feedback @ismailarilik ; if you are talking about https://github.com/ruby/www.ruby-lang.org/blob/master/Rakefile#L11 you are right its for the check:markup that use validate-website and require a website as argument but in fact the check is done with files locally build-ed.

If its not clear maybe we should print instead the path checked ? and bug could be reported to https://github.com/spk/validate-website

@stomar
Copy link
Contributor

stomar commented Mar 4, 2019

I removed HOST in 2bcc020, since displaying the URL while not checking it but the local files is confusing, see #1420.

@stomar stomar closed this as completed Mar 4, 2019
@spk spk mentioned this issue Mar 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@spk @stomar @ismailarilik