HTML validation on Travis has been discussed before, I think.

IMO it's a bad idea to check every build:

• it's really not necessary since the HTML layouts very rarely change; most commits only add/change markdown, which usually does not introduce malformed HTML
• it takes way too much time (the build of this PR took 8 min 22 s); note that there already have been complaints about the current 2...3 min

I rather think that occasional validations should be sufficient.

Hi, I've updated the PR using libtidy (around 40sec to check all files) and fixes the errors hope we could reconsider including the changes, thanks

It‘s a little confusing: this is supposed to target CI, but commit message says „locally“.

It‘s a little confusing: this is supposed to target CI, but commit message says „locally“.

you are right its confusing i will remove this

After a closer look I feel I have to close this PR, since it doesn‘t make any sense to run on CI in this form, and would even be harmful.

The problem is that the validation task does not check the current build but the already deployed site. This would mean that a PR introducing errors would not fail on CI, but all subsequent PRs would, regardless of whether they introduce errors or not.

As to the general question whether this check should (in a fixed version) be added to CI: 40 seconds is not too bad, but personally I’m still undecided and would like to have some other opinions.

@hsbt

The problem is that the validation task does not check the current build but the already deployed site. This would mean that a PR introducing errors would not fail on CI, but all subsequent PRs would, regardless of whether they introduce errors or not.

This is not correct this test the current branch since it check the build-ed _site generated on CI. cf https://github.com/ruby/www.ruby-lang.org/blob/master/lib/markup_checker.rb#L7

Reopened in #1990 to have team feedback

Then please remind me what is the meaning of the —site https://www.ruby-lang.org/ option?

Update: it seems besides getting displayed the URL has no use.