Skip to content

Fix ConFoo post #1449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 2, 2016
Merged

Fix ConFoo post #1449

merged 3 commits into from
Sep 2, 2016

Conversation

stomar
Copy link
Contributor

@stomar stomar commented Sep 2, 2016 •
edited
Loading

  • remove banner from first paragraph: this paragraph is shown as excerpt on the main page and archive pages and should not have banners in it
  • avoid use of "we" [only fixed in en version]: "we" suggests ruby-core or ruby-lang.org, so it should be avoided in third-party posts (see Use of “we” in news posts #1405)
  • fix typo for id (s/Confoo/ConFoo/)

@stomar stomar merged commit 7471c95 into ruby:master Sep 2, 2016
@stomar stomar deleted the fix-confoo-post branch September 2, 2016 14:33
@stomar stomar mentioned this pull request Sep 2, 2016
Merged
@afilina
Copy link
Contributor

afilina commented Sep 2, 2016

Good points, thanks! I'll refer to this next time I post an announcement.

@hsbt
Copy link
Member

hsbt commented Sep 3, 2016

👍 Thanks always.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stomar @afilina @hsbt