Translate ruby 2.4.0-preview2 released (ko) #1452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
|
|
||
| [ISO/IEC 30170:2012](http://www.iso.org/iso/iso_catalogue/catalogue_tc/catalogue_detail.htm?csnumber=59579)에서는 | ||
| Integer 클래스의 세부에 관해서 기술하고 있지 않아, | ||
| CRuby에서는 2개의 정수 클래스(Fixnum과 Bignum)를 가지고 있습니다. |
|
Look good to me when other comments are resolved. |
f55016e to
2ba63cf
Compare
|
Applied all comment :) |
|
|
||
| [ISO/IEC 30170:2012](http://www.iso.org/iso/iso_catalogue/catalogue_tc/catalogue_detail.htm?csnumber=59579)에서는 | ||
| Integer 클래스의 세부에 관해서 기술하고 있지 않아, | ||
| Ruby에서는 2개의 정수 클래스(Fixnum과 Bignum)를 가지고 있습니다. |
2ba63cf to
d24bc91
Compare
| 처리되지 않은 예외 때문에 스레드가 사망하는 경우, 알림을 받을 수 있게 됩니다. | ||
|
|
||
| `report_on_exception`의 기본값으로 무엇을 사용하면 좋을지, | ||
| 그리고 스레드가 조인이 없는 GCed일 때 보고서를 보여주는 report-on-GC에 대한 피드백을 보내주세요. |
There was a problem hiding this comment.
How about '스레드가 조인되지 않은 채 GC 되었을 때'?
There was a problem hiding this comment.
oh, i thought GCed is some keyword OTL.
thanks!
d24bc91 to
c4e3f4b
Compare
| 처리되지 않은 예외 때문에 스레드가 사망하는 경우, 알림을 받을 수 있게 됩니다. | ||
|
|
||
| `report_on_exception`의 기본값으로 무엇을 사용하면 좋을지, | ||
| 그리고 스레드가 조인되지 않은 채 GC 되었을 때 보고서를 보여주는 report-on-GC에 대한 피드백을 보내주세요. |
There was a problem hiding this comment.
How about just '알려주는' instead of '보고서는 보여주는'?
c4e3f4b to
b2bcacb
Compare
|
Thanks for a lot reviews! I will merge this 👍 |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ruby/www-ruby-lang-org-i18n-ko
Please Review this! XD