Corrected a sentence and a broken link #1478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
About the french books link: it now leads to a website in japanese for some unknown reason. I've searched on Google for a list of books available to learn Ruby, and I found this list on developpez.com: http://ruby.developpez.com/livres/ which is a useful resource to learn programming in a lot of languages, so I thought this link might be useful. There are some duplicates with the english list, though. I cannot choose whether I put it in or not, so it's up to you. I removed it for now.
|
Your first PR is merged 🎆 Thanks! I amended the commit message (see the final commit bd7e27c); note that PR description and commit message are different things. The latter should describe the actual change and reasons for it -- if necessary -- in a concise way. Your changes were so small that a commit message body isn't really necessary. For the PR description it's perfectly ok to provide more thoughts, alternatives, etc. I'm not sure about the possible new book list, yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the french books link: it now leads to a website in japanese for some unknown reason. I've searched on Google for a list of books available to learn Ruby, and I found this list on developpez.com: http://ruby.developpez.com/livres/ which is a useful resource to learn programming in a lot of languages, so I thought this link might be useful. There are some duplicates with the english list, though. I cannot choose whether I put it in or not, so it's up to you. I removed it for now.
(Also it's my first pull request ever (yaaaaay!), so I'm not sure if I'm doing it properly, but here it is anyway. Feel free to give me some advice!)