Skip to content

Note ruby/ruby#2058 as a known issue in 2.6.0 release announcement #1951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Note ruby/ruby#2058 as a known issue in 2.6.0 release announcement #1951

wants to merge 1 commit into from

Conversation

oshanz
Copy link
Contributor

@oshanz oshanz commented Jan 28, 2019 •
edited by JuanitoFatas
Loading

@oshanz oshanz requested a review from a team as a code owner January 28, 2019 09:24
@oshanz oshanz changed the title ruby/ruby#2058 Update 2018-12-25-ruby-2-6-0-released.md Update 2018-12-25-ruby-2-6-0-released.md Jan 28, 2019
@JuanitoFatas JuanitoFatas requested a review from ioquatix January 28, 2019 09:43
ioquatix
ioquatix approved these changes Jan 28, 2019
View reviewed changes
Copy link
Member

@ioquatix ioquatix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is okay but it needs input from long time maintainer too.

@JuanitoFatas JuanitoFatas requested review from sorah, znz and hsbt January 28, 2019 10:06
@hsbt
Copy link
Member

hsbt commented Jan 28, 2019

@nurse How about this update? I have no opinion this.

@sorah sorah changed the title Update 2018-12-25-ruby-2-6-0-released.md Note ruby/ruby#2058 as a known issue in 2.6.0 release announcement Jan 28, 2019
@ioquatix
Copy link
Member

I m am going to merge this by hand into the 2.6.1 release notes.

@ioquatix
Copy link
Member

@nurse this can be closed now it's merged into your branch.

@nurse
Copy link
Member

nurse commented Jan 30, 2019

Thanks! I merged your commit along with Ruby 2.6.1 release note.

@nurse nurse closed this Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ioquatix ioquatix ioquatix approved these changes

@sorah sorah Awaiting requested review from sorah

@znz znz Awaiting requested review from znz

@hsbt hsbt Awaiting requested review from hsbt

Assignees

@nurse nurse

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oshanz @hsbt @ioquatix @nurse