Skip to content

Conversation

mlen
Copy link
Contributor

@mlen mlen commented Jun 28, 2013

As in title.

@crabonature, you should probably review this PR.

@crabonature
Copy link
Contributor

@mlen, Many thanks for translation.

I have to mention two things, there is a commit message without mentioning translation language, from Wiki: "The affected translation should be mentioned in the commit message.", so commit message should have (pl) at the end, and the message is little too long, should be shorter than 50 characters.

Second thing is that you missed short information in translation "...and for dNSName of subjectAltName..." in second paragraph of Details section.

Could you add it?

@mlen
Copy link
Contributor Author

mlen commented Jun 28, 2013

I fixed the commit message and updated the translation.
I omitted the dNSName thing on purpose. I think it is a technical detail that really doesn't matter here. What matters is that an unsafe function has been used and that it may lead to MITM attacks. I'll add that back if you insist.

@crabonature
Copy link
Contributor

@mlen I insist ❤️

@stomar
Copy link
Contributor

stomar commented Jun 28, 2013

Please do not edit the content. This is the official vulnerability announcement from ruby-core. If nahi thinks he needs to provide detail, it's his decision.

@mlen
Copy link
Contributor Author

mlen commented Jun 28, 2013

There you go.

crabonature added a commit that referenced this pull request Jun 28, 2013
[pl] Translated latest security advisory
@crabonature crabonature merged commit 528eb61 into ruby:master Jun 28, 2013
@crabonature
Copy link
Contributor

@mlen Great job. Thanks a lot once more. 🍶

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants