Skip to content

Check markup on travis #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Check markup on travis #853

wants to merge 4 commits into from

Conversation

spk
Copy link
Contributor

@spk spk commented Sep 23, 2014

Hello,
It's a continuation of #844 and #832, to keep the website valid and have notification from travis on markup errors.

@spk
Copy link
Contributor Author

spk commented Sep 23, 2014

I need to work on this, the --quiet option only show errors, but the build is long (2785 files to check)
I will add some green dot maybe to know the build is working.

@spk
Copy link
Contributor Author

spk commented Sep 23, 2014

It's working now but the build take 20 minutes

@makimoto
Copy link
Contributor

Taking 20 minutes each build is a little hard.
(Our build takes about 10 mins now and I think it is too long...)

IMO rake check:markup should not be included in CI and be used manually.

@spk
Copy link
Contributor Author

spk commented Sep 24, 2014

Maybe check only modified pages or only Time.now.year pages will be faster.

Faster and this are the most changed files
@spk
Copy link
Contributor Author

spk commented Sep 24, 2014

@makimoto It's about 5 minutes now and it check all current year news, which are the most patched/added.

@stomar
Copy link
Contributor

stomar commented Sep 28, 2014

Still need to consider whether it's worth the extra time for each build.

And if we include this check, what about the others? Shouldn't we include them also...?

@spk
Copy link
Contributor Author

spk commented Sep 29, 2014

@stomar
Yes, it's not the best, but it's better than nothing I think right now.
I would be better to have a weekly "complete" build, but I don't think it's possible with travis-ci ?

@stomar
Copy link
Contributor

stomar commented Sep 29, 2014

After thinking it over again: I'm against including this test in every build. The tests should be run manually for gem updates, layout changes, and the like.

The current system with markdown and html templates avoids most of the markup errors.
And new posts are supposed to be proofread in the staging area (which should reveal markdown blunders like missing brackets for links). Faster staging is IMO much more useful than testing every typo fix for html markup errors.

Note that the vast majority of the recent markup fixes (#832) stem from "legacy" content transfered from the previous RadiantCMS site.

@spk
Copy link
Contributor Author

spk commented Sep 29, 2014

You are right about "legacy" markup fixes, feel free to close this PR.

@spk spk closed this Jan 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants