using File as a block so that it tears down once everything has completed, adding a API directly in stashes, and adding testing around it. (#378)

tarcinil · web-flow · commit 93414167d7f1 · 2018-08-01T09:16:42.000-05:00
Signed-off-by: Vern Burton &lt;me@vernburton.com&gt;
diff --git a/lib/git/lib.rb b/lib/git/lib.rb
@@ -604,10 +604,12 @@ def stashes_all
       arr = []
       filename = File.join(@git_dir, 'logs/refs/stash')
       if File.exist?(filename)
-        File.open(filename).each_with_index { |line, i|
-          m = line.match(/:(.*)$/)
-          arr << [i, m[1].strip]
-        }
+        File.open(filename) do |f|
+          f.each_with_index do |line, i|
+            m = line.match(/:(.*)$/)
+            arr << [i, m[1].strip]
+          end
+        end
       end
       arr
     end
diff --git a/lib/git/stashes.rb b/lib/git/stashes.rb
@@ -13,6 +13,17 @@ def initialize(base)
         @stashes.unshift(Git::Stash.new(@base, message, true))
       end
     end
+
+    #
+    # Returns an multi-dimensional Array of elements that have been stash saved.
+    # Array is based on position and name. See Example
+    #
+    # @example Returns Array of items that have been stashed
+    #     .all - [0, "testing-stash-all"]]
+    # @return [Array]
+    def all
+      @base.lib.stashes_all
+    end
     
     def save(message)
       s = Git::Stash.new(@base, message)
diff --git a/tests/units/test_stashes.rb b/tests/units/test_stashes.rb
@@ -32,5 +32,27 @@ def test_stash_unstash
       end
     end
   end
+
+  def test_stashes_all
+    in_temp_dir do |path|
+      g = Git.clone(@wbare, 'stash_test')
+      Dir.chdir('stash_test') do
+        assert_equal(0, g.branch.stashes.size)
+        new_file('test-file1', 'blahblahblah1')
+        new_file('test-file2', 'blahblahblah2')
+        assert(g.status.untracked.assoc('test-file1'))
+
+        g.add
+
+        assert(g.status.added.assoc('test-file1'))
+
+        g.branch.stashes.save('testing-stash-all')
+
+        stashes = g.branch.stashes.all
+
+        assert(stashes[0].include?('testing-stash-all'))
+      end
+    end
+  end
   
 end
