Skip to content

fixing file descriptor leakage #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2018
Merged

fixing file descriptor leakage #378

merged 1 commit into from
Aug 1, 2018

Conversation

tarcinil
Copy link
Contributor

@tarcinil tarcinil commented Aug 1, 2018

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Ensure all commits include DCO sign-off.
  • Ensure that your contributions pass unit testing.
  • Ensure that your contributions contain documentation if applicable.

Description

using File as a block so that it tears down once everything has completed - We operated on the each and left the file descriptor open.
adding a API directly in stashes
adding testing around it.

fixes #312

…eted, adding a API directly in stashes, and adding testing around it.

Signed-off-by: Vern Burton <me@vernburton.com>
@tarcinil tarcinil requested a review from perlun August 1, 2018 00:58
@tarcinil
Copy link
Contributor Author

tarcinil commented Aug 1, 2018

@coderanger :-)

Copy link
Contributor

@perlun perlun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections. Thanks for the fix @tarcinil!

@tarcinil tarcinil merged commit 9341416 into ruby-git:master Aug 1, 2018
@tarcinil tarcinil deleted the fix/312 branch August 1, 2018 14:16
@tarcinil
Copy link
Contributor Author

tarcinil commented Aug 1, 2018

@perlun Should we contemplate a minor bump for the recent changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stashes API leaks a file handle
3 participants