Skip to content

JRuby build is intermittently failing #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rvodden opened this issue Mar 31, 2018 · 1 comment
Closed

JRuby build is intermittently failing #358

rvodden opened this issue Mar 31, 2018 · 1 comment

Comments

@rvodden
Copy link
Contributor

rvodden commented Mar 31, 2018

From @perlun

I think the root cause here is that our code is not really thread safe, and that's why JRuby (which is much more concurrent than the evil-GIL-threaded MRI) triggers these errors.
[..]
The error:

Error: test_git_init_bare(TestThreadSafety): Git::GitExecuteError: git '--git-dir=/tmp/d20180328-6779-88i76v/.git' init '--bare' 2>&1:fatal: GIT_WORK_TREE (or --work-tree=) not allowed without specifying GIT_DIR (or --git-dir=)
...indicates that something goes wrong; it does specify the --git-dir but git still complains about this.

I read this SO thread but I couldn't see the GIT_WORK_TREE variable being set on the Travis machines.

rvodden added a commit that referenced this issue Mar 31, 2018
Issues #358 covers the full remediation of the issue.
rvodden added a commit that referenced this issue Mar 31, 2018
* Tweaking yaml build to reveal git version

* Permitted jruby build whilst its failing

Issues #358 covers the full remediation of the issue.
@perlun perlun added the pinned label May 16, 2018
@tarcinil tarcinil added the Bug label Aug 25, 2018
@jcouball
Copy link
Member

I believe this was fixed in #403 and released in v1.6.0.pre1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants