-
Notifications
You must be signed in to change notification settings - Fork 533
archive files generated with archive() may be corrupted #363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This is definitely still an issue. I don't believe I'm the one responsible for lack of progress here? |
Please stop continually marking this issue as stale. |
@poohblah I have pinned the issue so that stalebot will stop adding the wontfix. |
3 tasks
3 tasks
3 tasks
Fixed with #684 and released in git-2.0.0-pre1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Repository archives generated with the
archive()
method will be corrupted ifgit archive
prints anything to stderr.When I run git archive commands on the command line, sometimes stuff gets printed to stderr, while the archive itself is output to stdout:
However, I found that the line
X11 forwarding request failed on channel 0
was getting prepended to my archives generated when using ruby-git'sarchive()
method, resulting in a corrupted archive (note that "X1 archive" is not a valid archive type):This appears to be because
command()
indiscriminately redirects stderr to stdout andarchive()
callscommand()
while redirecting stdout into the archive file. The upshot is that ifgit archive
prints anything to stderr, the resulting archive will be corrupted.See also.
The text was updated successfully, but these errors were encountered: