A friendly reminder that this issue had no activity for 60 days.

why is this issue ignored? it takes 10 seconds to reproduce

got into a git repo, make some change,
run git describe --long --tags --dirty --always
40a48a9

compare with ruby git

run irb

irb(main):001:0> require 'git'
=> true
irb(main):002:0> puts Git.open(".").describe(nil, {long:true, tags:true, :dirty=>true, always:true})
40a48a9
=> nil

this is clearly a bug, why is this issue stale ?

@a4z this project was in a bit of slump for the past year or so. We are just getting it going again.

ah, OK, thanks for the information!

if you need some help, no problem

there is some inconsistency how parameters are taken by the function
the documentation says :dirty , a symbol, the implementation checks for a string, see

so this does not work
puts Git.open(".").describe(nil, {long:true, tags:true, dirty:true, always:true})
while this does
puts Git.open(".").describe(nil, {long:true, tags:true, 'dirty'=>true, always:true})

I guess, some other parameters of this function might have some similar problem

if this can wait (I guess it can) I can submit a PR the next or next next weekend, if no one else fixes it until then.
and I assume the implementation should be as the documentation says, yes?

I would really appreciate a PR that fixes this issue.

The implementation should be to use symbols as the key into the arr_opts hash and not strings.

You are correct that other options to describe have this problem... I think they are even worse:

      arr_opts << "--abbrev=#{opts['abbrev']}" if opts[:abbrev]
      arr_opts << "--candidates=#{opts['candidates']}" if opts[:candidates]
      arr_opts << "--match=#{opts['match']}" if opts[:match]

The if is looking up by symbol, but the string interpolation looks up by a string... that would never work.

I would take a fix for this to put things on the right track. However, this points out the need for better testing -- across the board.

PR done, not improved tests because unsure how to do it ,but I might look into it next time I find some time