Skip to content

Check if branch contains commit #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 12, 2018

Conversation

kwstannard
Copy link
Contributor

This allows the user to see if an arbitrary commit is contained within a
branch. For example you can check to see if a branch was merged into
master with git.branch('master').contains?('feature'). Or you can see
if your feature branch has the latest master commit with
git.branch('feature').contains?('master')

@ghost
Copy link

ghost commented Dec 19, 2014

👍

@robertodecurnex robertodecurnex force-pushed the master branch 2 times, most recently from 3fc1c27 to b224195 Compare February 25, 2016 17:56
@stale
Copy link

stale bot commented Apr 1, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 1, 2018
@kwstannard
Copy link
Contributor Author

I am no longer using ruby-git day to day. I wont update unless the maintainer is interested.

@stale stale bot removed the wontfix label Apr 4, 2018
@rvodden
Copy link
Contributor

rvodden commented Apr 5, 2018

@kwstannard if you could rebase it - I'll merge it in - it looks like a really helpful feature.

This allows the user to see if an arbitrary commit is contained within a
branch. For example you can check to see if a branch was merged into
master with `git.branch('master').contains?('feature')`. Or you can see
if your feature branch has the latest master commit with
  `git.branch('feature').contains?('master')`
@kwstannard kwstannard force-pushed the check_if_branch_contains_commit branch from 3c6e1db to de848e4 Compare April 5, 2018 14:04
@kwstannard
Copy link
Contributor Author

@rvodden updated, hope it helps.

@stale
Copy link

stale bot commented Jun 4, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 4, 2018
@stale stale bot removed the wontfix label Jun 4, 2018
@kwstannard
Copy link
Contributor Author

@rvodden

@perlun
Copy link
Contributor

perlun commented Jun 21, 2018

@kwstannard Sorry for the delay. Could you rebase one more time? (hopefully the last time...) Thanks.

@kwstannard
Copy link
Contributor Author

I am just going to close this. If you want it, I guess just open it and merge???

@kwstannard kwstannard closed this Jul 11, 2018
@perlun
Copy link
Contributor

perlun commented Jul 11, 2018

@kwstannard Ah, missed your comment about not using ruby-git so much anymore. It looks like a useful feature. I'll try to get it merged now, sorry for the delays and so forth.

@perlun perlun reopened this Jul 11, 2018
@perlun
Copy link
Contributor

perlun commented Jul 11, 2018

(also, I unfortunately didn't get any message after you rebased it the last time)

@kwstannard
Copy link
Contributor Author

@perlun

@kwstannard
Copy link
Contributor Author

Looks like you probably just need to restart that failed job

@tarcinil tarcinil closed this Jul 12, 2018
@tarcinil tarcinil reopened this Jul 12, 2018
@tarcinil
Copy link
Contributor

Closed and opened to trigger Travis.

@perlun perlun merged commit 3bbf612 into ruby-git:master Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants