Skip to content

Naively inject env into backticks and IO.popen #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

gudmundur
Copy link

Note: This is still WIP and is thought of as a proof of concept.

Rather than updating ENV and/or using Dir.chdir, inject the env directly into Ruby backticks and IO.popen.

robertodecurnex pushed a commit that referenced this pull request Sep 29, 2014
…modify each others env variables.

Adding --git-dir and --work-tree options to the git commands to prevent parallel executions to move the current working directory in the middle of each others process

related to #181
robertodecurnex pushed a commit that referenced this pull request Sep 29, 2014
…modify each others env variables.

Adding --git-dir and --work-tree options to the git commands to prevent parallel executions to move the current working directory in the middle of each others process

related to #181
@gudmundur
Copy link
Author

Closing this PR as the thread_safety branch is tackling this properly.

@gudmundur gudmundur closed this Sep 30, 2014
@gudmundur gudmundur deleted the inject_env branch September 30, 2014 08:24
robertodecurnex pushed a commit that referenced this pull request Dec 29, 2014
…modify each others env variables.

Adding --git-dir and --work-tree options to the git commands to prevent parallel executions to move the current working directory in the middle of each others process

related to #181
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant