Skip to content

Removed all Dir.chdir calls from private use #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

Removed all Dir.chdir calls from private use #195

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7661096
Removed the Dir.chdir in `list_files`
mbishop-fiksu Nov 26, 2014
6d623a6
Removed a Dir.chdir from `command`
mbishop-fiksu Nov 26, 2014
aad98f1
Removed a Dir.chdir from `self.export`
mbishop-fiksu Nov 26, 2014
3cdbdb0
Removed Dir.chdir from `repo_size`
mbishop-fiksu Nov 27, 2014
9683a32
Removed Dir.chdir from `construct_status`
mbishop-fiksu Nov 27, 2014
7d27728
Removed Dir.chdir from `config_get`.
mbishop-fiksu Nov 28, 2014
6d4d46a
Removed Dir.chdir from `config_list`.
mbishop-fiksu Nov 28, 2014
e22392a
Removed modern hash-syntax which broke compatibility for ruby 1.8
mbishop-fiksu Nov 28, 2014
858ead4
Removed `String#byteslice` call for 1.9.2 compatibility.
mbishop-fiksu Dec 1, 2014
70a8371
Added better 1.8-compatibility, but only by re-adding some `Dir.chdir…
mbishop-fiksu Dec 1, 2014
0f78b67
Added require 'open3' when needed and available.
mbishop-fiksu Dec 2, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removed Dir.chdir from construct_status
  • Loading branch information
@mbishop-fiksu
mbishop-fiksu committed Dec 1, 2014
commit 9683a3281fa3ebac9230f1004a7f21b38b903cc8
10 changes: 5 additions & 5 deletions lib/git/status.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,12 +89,12 @@ def construct_status
ignore = @base.lib.ignored_files

# find untracked in working dir
Dir.chdir(@base.dir.path) do
Dir.glob('**/*', File::FNM_DOTMATCH) do |file|
next if @files[file] || File.directory?(file) || ignore.include?(file) || file =~ /^.git\/.+/
prefix = "#{@base.dir.path}/"
Dir.glob(prefix+"**/*", File::FNM_DOTMATCH) do |abs_file|
file = abs_file.byteslice(prefix.length..-1)
next if @files[file] || File.directory?(file) || ignore.include?(file) || file =~ /^.git\/.+/

@files[file] = {:path => file, :untracked => true}
end
@files[file] = {:path => file, :untracked => true}
end

# find modified in tree
Expand Down