Skip to content

Fix for Ruby 1.9.1 #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix for Ruby 1.9.1 #20

wants to merge 1 commit into from

Conversation

jalada
Copy link

@jalada jalada commented Feb 17, 2011

This is mentioned in an issue in your repo, but the link to the commit fixing it in someone elses fork has gone.

@ivanvc
Copy link

ivanvc commented Nov 9, 2011

I've just stumbled with this problem, and seems like the fix you made, doesn't work. The issue, is that Dir.chdir accepts a block with one argument (the path from the new dir). So, the problem with setting the block argument to name, is that it will try to get a config named with the changed path, not the passed name. Therefore, the fix should be something like:

do_get = lambda do |path|
  command('config', ['--get', name])
end

Or with the 1.9 block syntax:

do_get = ->(path){command('config', ['--get', name])}

I've added a new pull request, see #35.

@jalada
Copy link
Author

jalada commented Nov 9, 2011

Ah OK, thanks :) I'll close this and trust that your change is the right one ;)

@jalada jalada closed this Nov 9, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants