Fix the encoding issue - 'split': invalid byte sequence in UTF-8 (up-to-date!!) #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ument Error) #190 - from up-to-date master
|
This pull request has exactly the same changes of #190, but made on top of the up-to-date master. |
robertodecurnex
added a commit
that referenced
this pull request
Feb 16, 2016
Fix the encoding issue - 'split': invalid byte sequence in UTF-8 (up-to-date!!) closes #190
|
Thanks for merging @robertodecurnex, if everything is fine I'd like to ask you to update the gem so that we can use the update on ruby. |
|
Thanks @davidvartanian for creating the updated pull-request and @robertodecurnex for merging it. @davidvartanian If you plan to use ruby-git in production or critical areas, I highly suggest that you look at the bug I posted - #194 It's a bad-logic bug and could come back to haunt you when you wouldn't expect. Any comments on the bug are welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the encoding issue - 'split': invalid byte sequence in UTF-8 (Argument Error) #190 - from up-to-date master