Fix encoding of command output #301
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamaradclimber
added a commit
to kamaradclimber/ruby-git
that referenced
this pull request
Dec 7, 2016
Before this patch, we always assumed the string was ascii-8bit which does not work correctly with real utf8 strings (french accented chars or chineese chars). This patch tries to use the string as utf8 and fallback if necessary to the the ascii-8bit assumption if necessary. This should help with ruby-git#295 and might replace the need for ruby-git#301. Change-Id: Idac63fa10e5aefafa1eb99a6be4138cac5f90ea0
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
For reference: A similar fix got merged in #327. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current solution and on Ruby 2.2 all non-ASCII are replaced even if they are valid UTF-8. I guess that solution works on Ruby 1.9 as the default encoding changed in 2.0, but I did not try that.
It looks like I'm not the only one experiencing the issue, see e.g. #295.