Skip to content

Set default location on #ls_files to . #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Set default location on #ls_files to . #320

wants to merge 3 commits into from

Conversation

gudmundur
Copy link

If a nil is passed in to #ls_files, git will output a warning about empty strings in pathspec. At a future date, git will start failing on such arguments. See here for more context.

@gudmundur
Set default location to .
ae40dfa 
If we pass in nil, git will output a warning about empty strings in
pathspec. See:
git/git@d426430
@gudmundur gudmundur changed the title Set default location to . Set default location on #ls_files to . Dec 14, 2016
@gudmundur
Copy link
Author

The failing test is the Ruby 1.9.2 matrix, and there's another PR to remove support for it, as it's been deprecated for months.

@mmack
Copy link

mmack commented Jan 29, 2018 •
edited
Loading

This gets more urgent since git version 2.16.0 - it now throws a error: https://github.com/git/git/blob/master/Documentation/RelNotes/2.16.0.txt#L6

@davewongillies davewongillies mentioned this pull request Feb 2, 2018
Closed
davewongillies added a commit to davewongillies/modulesync that referenced this pull request Feb 2, 2018
@davewongillies
Monkey patch ls_files until ruby-git/ruby-git#320 is resolved
f6e935a
@davewongillies davewongillies mentioned this pull request Feb 2, 2018
Merged
mmack
mmack suggested changes Feb 12, 2018
View reviewed changes
Copy link

@mmack mmack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not def ls_files(location=nil) ?

@schrepfler
Copy link

Is this being tackled?

nakhbari added a commit to fastlane/ci that referenced this pull request Mar 15, 2018
@nakhbari
Add monkey patch to fix ruby-git bug until ruby-git/ruby-git#320 is r…
0116a1d 
…esolved
@nakhbari nakhbari mentioned this pull request Mar 15, 2018
Merged
@stale
Copy link

stale bot commented Apr 27, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 27, 2018
@schrepfler
Copy link

This is still a problem.

@stale stale bot removed the wontfix label Apr 28, 2018
@perlun perlun added the pinned label Jun 20, 2018
@perlun
Copy link
Contributor

perlun commented Jun 20, 2018

I merged in master into this, but now the "changed files" says 0 files changed? Very odd. @gudmundur, thanks for the fix - if you or someone else could rebase this on top of the latest master, I'm happy to merge it in. Sorry for the huge delay of such a simple fix.

@perlun
Copy link
Contributor

perlun commented Jun 25, 2018

No feedback received. @gudmundur, if you'll do a rebase and ping me, I can reopen this. Closing for now.

@perlun perlun closed this Jun 25, 2018
@neomilium
Copy link

Fixed in #350

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmack mmack mmack requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gudmundur @mmack @schrepfler @perlun @neomilium