Skip to content

Enable mirror option for git clone and push #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 3, 2018

Conversation

guimaluf
Copy link
Contributor

c.f. https://help.github.com/articles/duplicating-a-repository

Updating original PR #167 from
Author: Lars Schneider larsxschneider@gmail.com
Date: Sat Aug 9 23:24:41 2014 -0700

@kylemacey
Copy link

@guimaluf Are you planning on getting the tests passing so this could get merged in?

c.f. https://help.github.com/articles/duplicating-a-repository

Updating original PR ruby-git#167 from
Author:    Lars Schneider <larsxschneider@gmail.com>
Date:      Sat Aug 9 23:24:41 2014 -0700
@guimaluf guimaluf force-pushed the mirror_opt_for_push_pull branch from b22e2cf to bbe95b9 Compare February 17, 2018 19:31
@kylemacey
Copy link

@guimaluf it looks like if you update your PR with the new commits in master from #344, it should fix up that JRuby test.

@tarcinil
Copy link
Contributor

@kylemacey I actually had that issue as well, and already had #344 pulled in; I fixed it in #348 which is awaiting review.

@kylemacey
Copy link

@robertodecurnex @perlun @rvodden (Not sure exactly who to @-mention, just grabbing based off activity that I see) can we get a hand getting #348 and this PR over the finish line?

@kylemacey
Copy link

Another bump on this. Is this ok to merge?

@guimaluf
Copy link
Contributor Author

If is needed I can rebase this... don't know what may be missing...

@dpmex4527
Copy link

Thanks @guimaluf! I don't see a lot of major changes since the last commit so test should still pass.

Copy link
Contributor

@perlun perlun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @guimaluf and others for this. 👍 Approving and merging now.

@perlun perlun merged commit 819d0d8 into ruby-git:master May 3, 2018
@guimaluf guimaluf deleted the mirror_opt_for_push_pull branch May 3, 2018 15:04
@dpmex4527
Copy link

@guimaluf, @perlun thanks for merging this!!! @perlun will this PR be 🚢'ing in the 2.0 release? (I'm basing this Q on this issue comment: #341 (comment))

@perlun
Copy link
Contributor

perlun commented May 14, 2018

@dpmex4527 Either 1.3.1 or 1.4 I think, since it doesn't really break any B/C. I'm hoping we can publish it shortly - please ping the other thread and ask if @rvodden if he will complete the work discussed there or if he'll hand it off to someone else.

@dpmex4527
Copy link

@perlun sounds good! Thanks for helping get this feature shipped out :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants