Fix ls-files for git 2.16 #350
Conversation
| @@ -396,6 +396,7 @@ def diff_index(treeish) | |||
| end | |||
|
|
|||
| def ls_files(location=nil) | |||
| location ||= '.' | |||
There was a problem hiding this comment.
Why not do this in the method arguments?
def ls_files(location='.')
...
endThere was a problem hiding this comment.
Sorry for the delay, I got no notification of your review. Thanks in advance :)
I thought about doing this, but then on ls_remote it was handled this way, so I kept the standard of code that was already there.
Having 2 standards seemed a bad idea to me. Also modifying ls_remote which is not subject of this PR didn't feel right.
But if you think it is not a problem modifying just here, I can change it. What do you think is best?
There was a problem hiding this comment.
You are correct about maintaining the standards. I had not seen ls_remote for my various use cases.
👍
| @@ -396,6 +396,7 @@ def diff_index(treeish) | |||
| end | |||
|
|
|||
| def ls_files(location=nil) | |||
| location ||= '.' | |||
There was a problem hiding this comment.
You are correct about maintaining the standards. I had not seen ls_remote for my various use cases.
👍
Since GIT version 2.16.0 empty pathspecs as alias to "everything" has been made illegal. A more detailed study this change's impact has been made at: ruby-git#345 (comment) Closes ruby-git#345
965ffee to
11e20a2
Compare
|
Thanks @tarcinil I've rebased from master so Github can FF merge. Could you have another look? |
This is now fixed upstream since 2018: ruby-git/ruby-git#350
Since GIT version 2.16.0 empty pathspecs as alias to "everything" has
been made illegal.
A more detailed study this change's impact has been made at:
#345 (comment)
Closes #345