Skip to content

Lib.ls_files raises error on newer git versions #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Lib.ls_files raises error on newer git versions #352

wants to merge 1 commit into from

Conversation

mhoyer
Copy link
Contributor

@mhoyer mhoyer commented Mar 6, 2018

I get this error when using ruby-git after updating my local git version:

Git::GitExecuteError: git "--git-dir=C:/temp/.git" "--work-tree=C:/temp" ls-files "--stage" ""  2>&1:fatal: empty string is not a valid pathspec. please use . instead if you meant to match all paths
C:/Ruby23/lib/ruby/gems/2.3.0/gems/git-1.3.0/lib/git/lib.rb:937:in `command'
C:/Ruby23/lib/ruby/gems/2.3.0/gems/git-1.3.0/lib/git/lib.rb:861:in `command_lines'
C:/Ruby23/lib/ruby/gems/2.3.0/gems/git-1.3.0/lib/git/lib.rb:400:in `ls_files'
C:/Ruby23/lib/ruby/gems/2.3.0/gems/git-1.3.0/lib/git/status.rb:88:in `construct_status'
C:/Ruby23/lib/ruby/gems/2.3.0/gems/git-1.3.0/lib/git/status.rb:8:in `initialize'
C:/Ruby23/lib/ruby/gems/2.3.0/gems/git-1.3.0/lib/git/base/factory.rb:63:in `new'
C:/Ruby23/lib/ruby/gems/2.3.0/gems/git-1.3.0/lib/git/base/factory.rb:63:in `status'
...

Do you see that strange command with this empty "" after "--stage"?

My environment

$ git --version
git version 2.16.2.windows.1

$ ruby -v
ruby 2.3.1p112 (2016-04-26 revision 54768) [i386-mingw32]

@mhoyer
Copy link
Contributor Author

mhoyer commented Mar 6, 2018

🤦‍♂️ I just recognized there is already #350 fixing exactly the same.

@mhoyer mhoyer closed this Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mhoyer