Creates CONTRIBUTOR and MAINTAINERS files #353
adding github templates for issues/pull requests
Signed-off-by: Vern Burton <me@vernburton.com>
- Loading branch information
commit 02d9a59f5df6ac7d2f4f6e62aa4ae36e3cdd55d4
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| ### Subject of the issue | ||
| Describe your issue here. | ||
|
|
||
| ### Your environment | ||
| * version of git and ruby-git | ||
| * version of ruby | ||
|
|
||
| ### Steps to reproduce | ||
| Tell us how to reproduce this issue. | ||
|
|
||
| ### Expected behaviour | ||
| What did you expect to happen? | ||
|
|
||
| ### Actual behaviour | ||
| What actually happened? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| ### Your checklist for this pull request | ||
| 🚨Please review the [guidelines for contributing](../CONTRIBUTING.md) to this repository. | ||
|
|
||
| - [ ] Ensure all commits include | ||
| - [ ] Ensure that your contributions pass unit testing. | ||
| - [ ] Ensure that your contributions contain documentation if applicable. | ||
|
|
||
| ### Description | ||
| Please describe your pull request. | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
include what?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should have been the DCO sign-off, but could be rendered moot by your other comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tarcinil Fair enough. Ping me or @rvodden once you have it rebased and we'll give it another look.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@perlun My branch has been rebased and comments addressed.
The thread safety issue has also struck on the Ruby 2.1.10 inside of Travis.