Skip to content

Update gemspec #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 16, 2018
Merged

Update gemspec #366

merged 2 commits into from
May 16, 2018

Conversation

perlun
Copy link
Contributor

@perlun perlun commented May 15, 2018

  • Fix homepage URL
  • Get the version from version.rb (less duplication)

Closes #341

@perlun
Update gemspec
b40dd6f 
- Fix homepage URL
- Get the version from version.rb (less duplication)

Closes #341
@perlun perlun mentioned this pull request May 15, 2018
Closed
dpmex4527
dpmex4527 requested changes May 15, 2018
View reviewed changes
Copy link

@dpmex4527 dpmex4527 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@perlun this looks great! One quick ask: can you update the URL on the README file?

@dpmex4527
Copy link

Huh, I just noticed that as of this morning the Gemnasium link no longer works and is now showing this

image

It links to a shutdown page by our friendos over at GitLab 😅 with this link: https://docs.gitlab.com/ee/user/project/import/gemnasium.html

Since Github now supports security alerts using the dependency graph, maybe we can get rid of that badge and enable it for this repo?

@perlun
Copy link
Contributor Author

perlun commented May 16, 2018

@dpmex4527 Sure, no problem. Please re-check. If you think this looks fine, I'll go ahead and merge and then try to do a release asap.

@perlun
Copy link
Contributor Author

perlun commented May 16, 2018

Since Github now supports security alerts using the dependency graph, maybe we can get rid of that badge and enable it for this repo?

Good point; I already removed the gemnasium badge actually. Will activate security alerts also, if it's not already there.

dpmex4527
dpmex4527 approved these changes May 16, 2018
View reviewed changes
Copy link

@dpmex4527 dpmex4527 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@perlun perlun merged commit 64c6fa0 into master May 16, 2018
@perlun perlun deleted the fix/gemspec branch May 16, 2018 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpmex4527 dpmex4527 dpmex4527 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@perlun @dpmex4527