Do not always chomp output #368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efb4149 to
e982722
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
e982722 to
d431000
Compare
d431000 to
4cc9973
Compare
8e0d81a to
16059cc
Compare
jcouball
requested changes
Nov 21, 2020
These internal function start to have too many arguments, and in order to avoid chomping when not applicable, we will need to add one more boolean. Pass a hash of option instead of distinct arguments to make it easier to scan the source code. No functionnal change. Signed-off-by: Romain Tartière <romain@blogreen.org>
This argument was not used, so no functional change. Signed-off-by: Romain Tartière <romain@blogreen.org>
This allows the #show method to return the actual content of a file when this file ends by a line feed. Signed-off-by: Romain Tartière <romain@blogreen.org>
No functional change. Signed-off-by: Romain Tartière <romain@blogreen.org>
16059cc to
f66cb25
Compare
|
@jcouball I rebased these changes on top of master. |
jcouball
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bunch of commits does some refactoring and adds a way to optionally disable chomping the output of commands.
This fixes #347 in respect to the
#showmethod. Other methods may need similar adjustment.