.travis.yml: Update supported Ruby versions #371
Conversation
There was a problem hiding this comment.
I think that this makes sense that we should only maintain versions that are not end-of-life. I also think that we should not be overly concerned with the patch versions of Ruby.
The only issue I saw was that jruby-9.2 is not a supported version of JRuby for Travis.
.travis.yml
Outdated
| - 2.3 | ||
| - 2.4 | ||
| - 2.5 | ||
| - jruby-9.2 |
There was a problem hiding this comment.
I do not see jruby-9.2 on the list of rubies for Travis and the build shows that can't find it.
Travis Rubies: http://rubies.travis-ci.org/
There was a problem hiding this comment.
Good point, I filed rvm/rvm#4414 about it.
The Travis list usually don't include all the RVM versions, but either way, jruby-9.2 is not a valid RVM version string in this case.
- Drop 1.9, 2.0 and 2.1 which are EOL - Update 2.3, 2.4 and 2.5 specifiers (only specify minor version, not patch level) - Update JRuby to use latest and greatest Signed-off-by: Per Lundberg <perlun@gmail.com>
Thanks for the feedback, I fixed the PR and squashed it (to retain the DCO comment). Feel free to re-check and I'll merge once you are fine with this. |
|
|
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.
Description
Because this change is breaking in nature, this will require a major version bump to comply with SemVer guidelines.