commit with custom author date #374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6f48fdb to
4c70c1c
Compare
tarcinil
suggested changes
Jul 7, 2018
tests/units/test_commit.rb
Outdated
| set_file_paths | ||
| end | ||
|
|
||
| def test_add |
There was a problem hiding this comment.
This should be in tests/units/test_lib.rb to ensure that things in Git::Lib are tested where they are expected.
The test name makes more sense as #test_commit_with_date in that file.
|
Thanks for the feedback, @tarcinil. It seems the project moved really forward since I've submitted the original PR - awesome! 🎉 I've updated the tests to fit the ones that previously existed. It even seems more clear to me, now. Let me know what you think 👍 |
tarcinil
suggested changes
Jul 10, 2018
tests/units/test_lib.rb
Outdated
|
|
||
| author_date = Time.new(2016, 8, 3, 17, 37, 0, "-03:00") | ||
|
|
||
| previous = @lib.commit_data('HEAD') |
There was a problem hiding this comment.
What does this provide? I do not see it being used anywhere.
9cfe491 to
720e46e
Compare
|
Good catch! It was a leftover from a previous version of the test. |
|
Please rebase your branch and I’ll merge it. |
Signed-off-by: mgarciaisaia <mgarciaisaia+github@gmail.com>
720e46e to
71beaf8
Compare
|
Sorry - hoped you could rebase it from here. There it is! 👍 |
tarcinil
approved these changes
Jul 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Honor
git commit --date=...flag.Re-submitting the stalled #315