Adding ruby-head and ruby 2.6 to Travis, removing C ext from repo #382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vern Burton <me@vernburton.com>
Signed-off-by: Vern Burton <me@vernburton.com>
Signed-off-by: Vern Burton <me@vernburton.com>
Signed-off-by: Vern Burton <me@vernburton.com>
Signed-off-by: Vern Burton <me@vernburton.com>
Signed-off-by: Vern Burton <me@vernburton.com>
…wer versions are missing much of the support (Source: https://github.com/jruby/jruby-cext). adding jruby back to the standard matrix Signed-off-by: Vern Burton <me@vernburton.com>
AgoraSecurity
pushed a commit
to AgoraSecurity/ruby-git
that referenced
this pull request
Feb 21, 2020
…by-git#382) * removing un-needed elements from travis Signed-off-by: Vern Burton <me@vernburton.com> * removing cext which is not supported in travis Signed-off-by: Vern Burton <me@vernburton.com> * using double quotes Signed-off-by: Vern Burton <me@vernburton.com> * adding matrix form Signed-off-by: Vern Burton <me@vernburton.com> * using a different matrix Signed-off-by: Vern Burton <me@vernburton.com> * install bundler in jruby Signed-off-by: Vern Burton <me@vernburton.com> * removing .jrubyrc as C extension support was deprecated in 1.7 and newer versions are missing much of the support (Source: https://github.com/jruby/jruby-cext). adding jruby back to the standard matrix Signed-off-by: Vern Burton <me@vernburton.com> Signed-off-by: Agora Security <github@agora-security.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.
Description
I am adding ruby-head (allows failure) and ruby 2.6 which is in its second preview which should be a release candidate soon if following Ruby's release patterns.
Removing .jrubyrc from the repo as jruby has deprecated C ext support from the the library as of 1.7 and we are testing at 9.2 (Ruby 2.5 equiv.).
Source:
https://github.com/jruby/jruby-cext#status
https://twitter.com/headius/statuses/281091403919003649
Removing the before_install section as all of those steps are standard parts of Travis CI and appear under the
ruby.versionssection.