Skip to content

Refactor git config #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Refactor git config #400

wants to merge 3 commits into from

Conversation

mpapis
Copy link
Contributor

@mpapis mpapis commented Jan 21, 2019 •
edited
Loading

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Ensure all commits include DCO sign-off.
  • Ensure that your contributions pass unit testing.
  • Ensure that your contributions contain documentation if applicable.

Description

The Git module has config and global_config methods that are available only when Git module is included. Refactored the code to remove duplication and to make it more explicit we are managing git config not the library setup.

@mpapis mpapis force-pushed the refactor_Git_config branch from 7674f64 to dad56fc Compare January 21, 2019 14:21
@mpapis
Copy link
Contributor Author

mpapis commented Jan 21, 2019

the failing test is not related to the changes, it fails the same way on ruby-head for longer time

@mpapis mpapis mentioned this pull request Jan 22, 2019
Open
@jcouball jcouball mentioned this pull request Jan 30, 2019
Merged
3 tasks
@stale
Copy link

stale bot commented Mar 22, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added wontfix and removed wontfix labels Mar 22, 2019
Michal Papis added 2 commits March 25, 2019 14:41
Fix Git module config method
7b74894 
The Git module config method when used via `include Git` does not work
as the `lambda` requires parameters to be present and the second part of
condition in Git::Lib::config_get calls the lambda without any params,
switching to `Proc.new` fixes the problem.

Signed-off-by: Michal Papis <michal.papis@toptal.com>
Refactor Git::config
117b45f 
The Git module has config and global_config methods that are available
only when Git module is included. Refactored the code to remove
duplication and to make it more explicit we are managing `git config`
not the library setup.

Signed-off-by: Michal Papis <michal.papis@toptal.com>
@mpapis mpapis force-pushed the refactor_Git_config branch from dad56fc to 117b45f Compare March 25, 2019 13:43
@mpapis
Copy link
Contributor Author

mpapis commented Mar 25, 2019

tests are passing, the code is rebased, anything else I should do?

@stale
Copy link

stale bot commented May 24, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label May 24, 2019
@mpapis
Copy link
Contributor Author

mpapis commented May 28, 2019

still waiting for the review

@stale stale bot removed the wontfix label May 28, 2019
@stale
Copy link

stale bot commented Jul 27, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jul 27, 2019
@mpapis
Copy link
Contributor Author

mpapis commented Jul 30, 2019

still waiting for the review

@stale stale bot removed the wontfix label Jul 30, 2019
@stale
Copy link

stale bot commented Sep 28, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Sep 28, 2019
@mpapis
Copy link
Contributor Author

mpapis commented Sep 30, 2019

still waiting for the review

@stale stale bot removed the wontfix label Sep 30, 2019
@stale
Copy link

stale bot commented Nov 29, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 29, 2019
@mpapis
Copy link
Contributor Author

mpapis commented Nov 29, 2019

still waiting for the review

@stale stale bot removed the wontfix label Nov 29, 2019
@mpapis mpapis mentioned this pull request Dec 2, 2019
Closed
3 tasks
@stale
Copy link

stale bot commented Jan 28, 2020

A friendly reminder that this issue had no activity for 60 days.

@stale stale bot added the stale label Jan 28, 2020
@stale stale bot removed the stale label Dec 28, 2020
@stale
Copy link

stale bot commented Jun 11, 2021

A friendly reminder that this issue had no activity for 60 days.

@stale stale bot added the stale label Jun 11, 2021
@jcouball jcouball mentioned this pull request Mar 9, 2023
Open
@jcouball
Copy link
Member

jcouball commented Mar 9, 2023

I am closing this PR to have a broader discussion about how git config should work in this gem in the next major release in #656.

@jcouball jcouball closed this Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpapis @jcouball