Skip to content

Fix string with wrongly detected cp #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix string with wrongly detected cp #410

wants to merge 2 commits into from

Conversation

majioa
Copy link

@majioa majioa commented Mar 27, 2019 •
edited
Loading

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Ensure all commits include DCO sign-off.
  • Ensure that your contributions pass unit testing.
  • Ensure that your contributions contain documentation if applicable.

Description

  • fixes conversion from the invalid detectedfsource codepage string when
    used String#split method

The bug can be reproduced as follows:

  1. Clone git: git://git.altlinux.org/gears/g/gdesklets.git
  2. See the commit message has an invalid char, but is detected by the git-lib as UTF-8
    $ git show 606eae4fd5f5b9f772e1feedddf4b97016494ece
  3. Use the method "#command_lines" of Git::Lib on the commit.

@majioa
Fix string with invalidly detected cp
9cd565d 
- fixes conversion from the invalid detectedfsource codepage string when
  used String#split method

Signed-off-by: Malo Skrylevo <majioa@yandex.ru>
@majioa majioa changed the title Fix string with invalidly detected cp Fix string with wrongly detected cp Mar 27, 2019
@majioa
process_commit_data
6455820 
Skip processing if message body is blank:

- fixes an error when lib is trying to process message body in #process_commit_data,
  and throws an nil access method exception

Signed-off-by: Malo Skrylevo <majioa@yandex.ru>
@stale
Copy link

stale bot commented Jun 21, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 21, 2019
@majioa
Copy link
Author

majioa commented Jun 28, 2019

@schacon @josh @technicalpickles what can be done ?

@stale stale bot removed the wontfix label Jun 28, 2019
@stale
Copy link

stale bot commented Aug 27, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Aug 27, 2019
@majioa
Copy link
Author

majioa commented Aug 28, 2019

@schacon @josh @technicalpickles ping

@stale stale bot removed the wontfix label Aug 28, 2019
@stale
Copy link

stale bot commented Oct 27, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 27, 2019
@stale stale bot closed this Nov 3, 2019
@jcouball
Copy link
Member

@majioa can you please see if this is fixed in 1.6.0.pre1 version? I think this issue might be fixed by #405.

@jcouball jcouball reopened this Jan 21, 2020
@jcouball
Copy link
Member

I believe #405 (included the 1.6.0.pre1 release) fixes the issue you reported:

$ gem list git

*** LOCAL GEMS ***

git (1.6.0.pre1)
$ git clone git://git.altlinux.org/gears/g/gdesklets.git
Cloning into 'gdesklets'...
remote: Counting objects: 2094, done.
remote: Compressing objects: 100% (940/940), done.
remote: Total 2094 (delta 1117), reused 2094 (delta 1117)
Receiving objects: 100% (2094/2094), 5.09 MiB | 1.91 MiB/s, done.
Resolving deltas: 100% (1117/1117), done.
$ cd gdesklets
$ irb
2.6.5 :001 > require 'git'
 => true
2.6.5 :002 > g = Git.open '.'
 => #<Git::Base:0x00007fab960c1090 @logger=nil, @working_directory=#<Git::WorkingDirectory:0x00007fab960c0f28 @path="/Users/couballj/SynologyDrive/Documents/Projects/ruby-git/gdesklets">, @repository=#<Git::Repository:0x00007fab960c0e10 @path="/Users/couballj/SynologyDrive/Documents/Projects/ruby-git/gdesklets/.git">, @index=#<Git::Index:0x00007fab960c0cf8 @path="/Users/couballj/SynologyDrive/Documents/Projects/ruby-git/gdesklets/.git/index">>
2.6.5 :003 > g.gcommit('606eae4fd5f5b9f772e1feedddf4b97016494ece').message
 => "0.26.2-alt0.2\n\n- move all desklets to Applications/Monitoring in menu hierarÓhy.\n- use freedesktop2menu.pl to build menu file.\n- update buildreqs to fix python dependencies."
2.6.5 :004 >

If you find this is not the case, please reopen with steps to reproduce the problem you are seeing.

@jcouball jcouball closed this Jan 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@majioa @jcouball