Are there any changes you'd like me to make to this PR?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Thank you for this contribution!

One thing I do not like about this is that you set the attribute with a truthy value, but it returns a string.

One might be tempted to set the value to 'false' which would return 'true' when queried later:

2.7.2 :001 > c = Git::Config.new
 => #<Git::Config:0x00007f8acf8f7350 @binary_path=nil, @git_ssh=nil, @git_ssl_no_verify=nil>
2.7.2 :002 > c.git_ssl_no_verify
 => nil
2.7.2 :003 > c.git_ssl_no_verify = 'true'
 => true
2.7.2 :004 > c.git_ssl_no_verify
 => "true"
2.7.2 :005 > c.git_ssl_no_verify = 'false'
 => "false"
2.7.2 :006 > c.git_ssl_no_verify
 => "true"
2.7.2 :007 >

Also, c.git_ssl_no_verify overrides the GIT_SSL_NO_VERIFY environment variable ONLY if c.git_ssl_no_verify is set to a non-truthy value. What is someone wants to use this option to disable the GIT_SSL_NO_VERIFY command? For this case, I think that you should only fallback to the environment variable if @git_ssl_no_verify is unset.

I think two options for this interface that would be better:

1. Allow the user to set the value as a string and don't have an opinion about what is true/false/valid. It would simply be passed as-is to the command. If unset, use the environment variable.

2. Have an opinion about what is valid and accept only values that git allows to represent a boolean value. Valid values are documented in the boolean section of git-config. If unset, use the environment variable.

Closing this PR without accepting it.

You can set the http.sslVerify global config option to accomplish this for all repositories:

Git.global_config('http.sslVerify', 'false')

For specific repos, you can clone with that option:

git.clone(<path>, config: ['http.sslVerify=false'])

Alternately, the GIT_SSL_NO_VERIFY environment variable still works.