Skip to content

Removed blank (1 char change) after method name to fix this warning: #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

jasnow
Copy link

@jasnow jasnow commented Dec 22, 2019

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Ensure all commits include DCO sign-off.
  • Ensure that your contributions pass unit testing.
  • Ensure that your contributions contain documentation if applicable.

Description

Removed blank (1 char change) after method name to fix this warning:

Users/USER/rvm/gems/ruby-2.7.0-rc1@ruby2.7-no-rails/gems/git-1.5.0/lib/git/branch.rb:40:
warning: parentheses after method name is interpreted as an argument list, not a decomposed argument

jcouball and others added 3 commits December 22, 2019 11:34
…ing does not raise an exception (ruby-git#405)

Signed-off-by: James Couball <jcouball@yahoo.com>
Signed-off-by: Al Snow <jasnow@hotmail.com>
Signed-off-by: Al Snow <jasnow@hotmail.com>
@AgoraSecurity
Copy link
Contributor

Looks good

@jasnow
Copy link
Author

jasnow commented Jan 12, 2020

@robertodecurnex - Can you assign a "reviewer with write access" to review this 1 char change since a review is required before merging? Thanks.

Copy link
Member

@jcouball jcouball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Thank you!

@jcouball
Copy link
Member

@jasnow can you please rebase with master? If you do that, I will get this change merged.

@jasnow
Copy link
Author

jasnow commented Jan 22, 2020

Bye

@jasnow jasnow closed this Jan 22, 2020
@jcouball
Copy link
Member

Sorry to see you go @jasnow. I created #439 for this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants