Add new maintainer and add release instructions #437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perlun
reviewed
Jan 23, 2020
| in this guide | ||
| * Create a new tag using [git-extras](https://github.com/tj/git-extras/blob/master/Commands.md#git-release) | ||
| `git release` command | ||
| * For example: `git release v1.6.0.pre1` |
There was a problem hiding this comment.
Should the tag really be made in the actual PR? This will work but only as long as we are strict with using --ff-only-style merging (fast forward merges without merge commits).
The other option would be to tag it once the PR is merged instead.
perlun
approved these changes
Jan 23, 2020
|
|
||
| * Verify that you are not on a fork with the command `git remote -v` | ||
| * Verify that the version number is correct by running `rake -T` and inspecting | ||
| the output for the `release[remote]` task |
There was a problem hiding this comment.
It's also possible to have multiple remotes in a git working copy; this is how I typically do it both at work. But I'm not sure it plays that well with the rake release command, so feel free to keep this like it's phrased if it works best for you that way.
Add instructions for releasing the git gem Signed-off-by: James Couball <jcouball@yahoo.com>
AgoraSecurity
pushed a commit
to AgoraSecurity/ruby-git
that referenced
this pull request
Feb 21, 2020
Add instructions for releasing the git gem Signed-off-by: James Couball <jcouball@yahoo.com>Signed-off-by: Agora Security <github@agora-security.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.
Description