Update instructions for making contributions #438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perlun
approved these changes
Jan 24, 2020
CONTRIBUTING.md
Outdated
|
|
||
| In the commit message of the contribution, the developer simply adds a Signed-off-by statement and thereby agrees to the DCO, which you can find below or at <http://developercertificate.org/>. | ||
| ### 1 PR = 1 Commit | ||
| * All commits for a PR must be squashed one commit |
There was a problem hiding this comment.
Suggested change
| * All commits for a PR must be squashed one commit | |
| * All commits for a PR must be squashed into one commit |
The intent was to structure the instructions better without making actual changes to the contribution rules. Signed-off-by: James Couball <jcouball@yahoo.com>
AgoraSecurity
pushed a commit
to AgoraSecurity/ruby-git
that referenced
this pull request
Feb 21, 2020
The intent was to structure the instructions better without making actual changes to the contribution rules. Signed-off-by: James Couball <jcouball@yahoo.com>Signed-off-by: Agora Security <github@agora-security.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.
Description
The intent was to structure the instructions better without making actual changes to the contribution rules.