Skip to content

fix broken link in a PR template again #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2020

Conversation

yuta1024
Copy link
Contributor

@yuta1024 yuta1024 commented Feb 4, 2020

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Ensure all commits include DCO sign-off.
  • Ensure that your contributions pass unit testing.
  • Ensure that your contributions contain documentation if applicable.

Description

This PR changes a relative link to an absolutely link.
Please see #444 (comment) .

Signed-off-by: Yuta Harima <yuu725@gmail.com>
@yuta1024 yuta1024 mentioned this pull request Feb 4, 2020
3 tasks
Copy link
Member

@jcouball jcouball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Thank you for your contribution!

@jcouball jcouball merged commit 5c89ef6 into ruby-git:master Feb 4, 2020
@yuta1024
Copy link
Contributor Author

yuta1024 commented Feb 5, 2020

Thanks!

@yuta1024 yuta1024 deleted the fix_broken_link_again branch February 5, 2020 13:07
AgoraSecurity pushed a commit to AgoraSecurity/ruby-git that referenced this pull request Feb 21, 2020
Signed-off-by: Yuta Harima <yuu725@gmail.com>Signed-off-by: Agora Security <github@agora-security.com>
@jcouball jcouball mentioned this pull request Apr 19, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants