Skip to content

Fix describe command's dirty, abbrev, candidates, and match options #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 6, 2020
Merged

Fix describe command's dirty, abbrev, candidates, and match options #447

merged 1 commit into from
Feb 6, 2020

Conversation

a4z
Copy link
Contributor

@a4z a4z commented Feb 5, 2020 •
edited
Loading

Your checklist for this pull request

  • Ensure all commits include DCO sign-off.
  • Ensure that your contributions pass unit testing.
  • Ensure that your contributions contain documentation if applicable.

Description

fix #429 , make implementation work like documentation states it

@a4z
fix ruby-git#429 , using symbols to access options
f2ae30c 
Signed-off-by: a4z <harald.achitz@gmail.com>
@jcouball jcouball changed the title fix #429 , using symbols to access options Fix describe --dirty, --abbrev, --candidates, and --match options Feb 6, 2020
@jcouball jcouball changed the title Fix describe --dirty, --abbrev, --candidates, and --match options Fix describe command's dirty, abbrev, candidates, and match options Feb 6, 2020
jcouball
jcouball approved these changes Feb 6, 2020
View reviewed changes
Copy link
Member

@jcouball jcouball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Thank you for your contributions.

@jcouball jcouball merged commit c85dd82 into ruby-git:master Feb 6, 2020
AgoraSecurity pushed a commit to AgoraSecurity/ruby-git that referenced this pull request Feb 21, 2020
@a4z @AgoraSecurity
Fix describe command's dirty, abbrev, candidates, and match options (r…
703b890 
…uby-git#447)

Signed-off-by: a4z <harald.achitz@gmail.com>Signed-off-by: Agora Security <github@agora-security.com>
@jcouball jcouball mentioned this pull request Apr 19, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcouball jcouball jcouball approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Git::Base(or Lib)#describe does not output dirty flag, even if it was requested
2 participants
@a4z @jcouball