Skip to content

Add YARD documentation to ruby-git #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add YARD documentation to ruby-git #448

wants to merge 1 commit into from

Conversation

jcouball
Copy link
Member

@jcouball jcouball commented Feb 9, 2020

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Ensure all commits include DCO sign-off.
  • Ensure that your contributions pass unit testing.
  • Ensure that your contributions contain documentation if applicable.

Description

Create YARD documentation for ruby-git instead of rdoc. Make improvements to the documentation.

@jcouball
Copy link
Member Author

jcouball commented Feb 9, 2020

@perlun CONTRIBUTING.md says that this project requires YARD documentation (even before I rewrote it), but YARD was not really used at all. RDoc was used inconsistently.

I was wondering if you thought it would be a good idea to add YARD documentation?

The work done so far shows what this would look like for most methods in the Git module like Git.bare, Git.open, Git.clone, Git.init.

In order to see this updated documentation, you will need to clone jcouball/ruby-git, and then run:

bundle install
bundle exec rake yard && open doc/index.html

Two areas to look at are the Git module and the Files page (accessed by clicking the 'Files' link in the top left under where it says 'Class List'.

@jcouball
Copy link
Member Author

jcouball commented Feb 9, 2020

One interesting thing is that documenting the project has given me some good ideas for refactoring parts that are a little confusing.

@jcouball
Copy link
Member Author

jcouball commented Feb 9, 2020

Today I learned that RubyGems automatically generates and hosts documentation for every gem published to rubygems.org at https://rubydoc.info. For instance: https://rubydoc.info/gems/git

@perlun
Copy link
Contributor

perlun commented Mar 14, 2020

@jcouball No strong feelings from my end as to whether to go with RDoc or YARD. I've used the latter previously myself though. In any case, we should definitely make it look good at https://rubydoc.info/gems/git

@stale
Copy link

stale bot commented Jun 5, 2020

A friendly reminder that this issue had no activity for 60 days.

@stale stale bot added the stale label Jun 5, 2020
@jcouball
Copy link
Member Author

I recreated this PR in #502

@jcouball jcouball closed this Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants