Add support for git 2.25 and ruby 2.7 #463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Terceiro <asa@terceiro.xyz>
On git 2.20, that '--' gets ignored, but on newer versions, at least from git 2.25+, it gets into the stash message. Signed-off-by: Antonio Terceiro <asa@terceiro.xyz>
Rakefile loads git.gemspec which already adds lib/ to the $LOAD_PATH. This also makes it possible to run the tests against the library installed system-wide. Signed-off-by: Antonio Terceiro <asa@terceiro.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made these changes while preparing a new upload of ruby-git for Debian.
The last commit is not necessarily related to supporting the new git and ruby, but it has no effect for upstream developers while making the life of downstream maintainers easier. Please consider accepting it as well, but if not I can drop it from this PR.