Allows a logger to be given during cloning #473
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A friendly reminder that this issue had no activity for 60 days. |
645e227 to
9256f51
Compare
9256f51 to
a7114ee
Compare
Modifies the clone method in the Base class to allow it to receive and use a logger during the clonning phase as well as pass it down to the class constructor so that the created instance has access to it as well. Signed-off-by: Sergio Bobillier <sergio.bobillier@esrlabs.com>
a7114ee to
78b884a
Compare
|
A friendly reminder that this issue had no activity for 60 days. |
|
This was fixed in #501 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
🚨 Please review the guidelines for contributing to this repository.
Description
Currently, if you pass a logger to the
clonemethod in the Base class it is completely ignored, not only it is not used during the cloning phase but the resultingBaseinstance doesn't have the logger attached to it, meaning that all subsequent operations over that repository are not logged.This Pull Request attempts to remedy that by adding code to pass the logger object to the constructor of the
Git::Libclass as well as to the constructor of theBaseclass itself.In order to avoid coupling the classes (more than they already are) I decided to merge the logger to the Hash returned by the
clonemethod of theGit::Libclass instead of passing it and then having the method return it in the resultingHash.