Skip to content

Add gem build, install, and sanity test to the CI build #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2021
Merged

Add gem build, install, and sanity test to the CI build #509

merged 1 commit into from
Jan 11, 2021

Conversation

jcouball
Copy link
Member

@jcouball jcouball commented Jan 1, 2021

Signed-off-by: James Couball jcouball@yahoo.com

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Ensure all commits include DCO sign-off.
  • Ensure that your contributions pass unit testing.
  • Ensure that your contributions contain documentation if applicable.

Description

The current CI build runs the unit tests but does not actually build the gem, install it, or try to use the gem that was built to make sure it was built correctly.

This change is meant to stop issues like the one reported in #506 from being published as a gem.

This change addresses all that by:

  • Updating the default Rake task to build the gem.
  • Adding a new Rake task test:gem that installs the gem and runs a sanity test using the installed gem.
  • Add a new step to the CI build that runs the test:gem rake task.

@jcouball jcouball requested a review from frankthrock January 7, 2021 18:36
Signed-off-by: James Couball <jcouball@yahoo.com>
@jcouball jcouball changed the title Add gem build, install, and sanity test to CI build Add gem build, install, and sanity test to the CI build Jan 10, 2021
Copy link

@frankthrock frankthrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good. Thank you!

@jcouball jcouball merged commit d1b1711 into ruby-git:master Jan 11, 2021
@jcouball jcouball mentioned this pull request Jan 15, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants