Refactor how working, repository, and index directories are initialized #514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcouball
commented
Jan 21, 2021
| @@ -44,8 +44,7 @@ def test_git_init | |||
| def test_git_init_bare | |||
| in_temp_dir do |path| | |||
| repo = Git.init(path, :bare => true) | |||
| assert(File.directory?(File.join(path, '.git'))) | |||
| assert(File.exist?(File.join(path, '.git', 'config'))) | |||
| assert(File.exist?(File.join(path, 'config'))) | |||
There was a problem hiding this comment.
Git.init should create the new, bare repository in the directory given by path and not in the .git subdirectory of path. This was a bug.
Signed-off-by: James Couball <jcouball@yahoo.com>
jcouball
commented
Jan 21, 2021
| @@ -24,7 +24,7 @@ def test_git_init_bare | |||
| threads.each(&:join) | |||
|
|
|||
| dirs.each do |dir| | |||
| Git.bare("#{dir}/.git").ls_files | |||
| Git.bare(dir).ls_files | |||
There was a problem hiding this comment.
Git.init should create the new, bare repository in the directory given by dir and not in the .git subdirectory of dir. This was a bug.
|
A friendly reminder that this issue had no activity for 60 days. |
|
Replaced this PR with #544 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: James Couball jcouball@yahoo.com
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.
Description
When opening a submodule or secondary working tree which exist in a directory different than the current directory, the command would fail.
The logic for how to set working tree, repository, and index directories is scattered all over the place. This PR tries to centralize that logic.