Skip to content

Added allow_unrelated_histories option support for pull #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Added allow_unrelated_histories option support for pull #521

wants to merge 3 commits into from

Conversation

iSimar
Copy link

@iSimar iSimar commented Jun 15, 2021

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Ensure all commits include DCO sign-off.
  • Ensure that your contributions pass unit testing.
  • Ensure that your contributions contain documentation if applicable.

Description

Please describe your pull request.

@jcouball
Copy link
Member

I am willing to take these changes with the following additions:

  • Update the description of the PR. Also note that you are adding --rebase flag too (or remove the addition of the rebase flag)
  • Squash your commits and include the DCO sign off on the resulting commit
  • Add tests for the new options
  • Document Git::Lib#pull and Git::Base#pull for the options added
  • Add examples in the README.md

Please see the CONTRIBUTING document for help.

@iSimar iSimar closed this Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iSimar @jcouball