fix utf8 issue + remove deprecated has_rdoc #54
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This UTF-8 bug still occurs in 1.2.6. Any plans to merge this? |
|
I would also like to see this merged because it fixes an error for me because this commit puppetlabs/puppet@d27af92 accidentally snuck in a unicode nbsp in the log message. |
3fc1c27 to
b224195
Compare
|
Thank @ut. Would you have a chance to rebase this on top of the current |
|
Alright, great! Thanks for the confirmation. Closing this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i fixed the utf8 issue (which occurs if non-latin1 chars are used in a git commit message) with a solution described in issue #33 and by the way i removed a deprecated syntax for rdoc