Add --all flag to fetch method #579
Conversation
0340550 to
33cf510
Compare
The fix for CVE-2022-25648 broke a workflow for us by removing the ability to fetch all remotes. This adds --all to the list of available flags for the #fetch method. It does not add :a as an alternative flag, as git fetch -a and git fetch --all are not the same thing. Signed-off-by: Matthew Riedel <matthew.riedel@fluxfederation.com>
33cf510 to
13ac421
Compare
|
@matthewriedel-flux thank you for reporting this issue and submitting a fix for it. As I reviewed this PR, I was going to give feedback to add tests for the new --all options and permutations. However, I realized that there isn't a good example to point to in the body of tests that shows how to do this. As a response, I created PR #583 which incorporates your changes (with a tweak or two) AND adds tests to test that the command line is generated as expected for different permutations of the fetch command. I created Test::Unit::TestCase#assert_command_line which should simplify creation of test cases that only test that the command line is generated in a particular way for given Git::Base method. In these cases, the git command line isn't actually called. I am hoping this helps improve the tests and speeds up the test suite. I'd be interested in your feedback in that PR. |
|
Closing this in favor of PR #583 |
The fix for CVE-2022-25648 broke a workflow for us by removing the ability
to fetch all remotes.
This adds --all to the list of available flags for the #fetch method. It does
not add
:aas an alternative flag, asgit fetch -aandgit fetch --allarenot the same thing.
Signed-off-by: Matthew Riedel matthew.riedel@fluxfederation.com
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.
Description
Please describe your pull request.