Skip to content

Fix Git::Lib#commit_data for GPG-signed commits #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 2, 2023
Merged

Fix Git::Lib#commit_data for GPG-signed commits #610

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c96ebed
Introduce example repo with a signed commit
Jan 16, 2023
e17afc9
Fix parsing of multiline gpgsig commit header field
Jan 16, 2023
2723cd3
Extract commit header parsing
Jan 16, 2023
cc12203
Use cat-file header parsing for Git::Lib#tag_data
Jan 17, 2023
2952ced
Remove unnecessary default tag/commit message values
Jan 16, 2023
59dd023
Remove #process_commmit_data indent parameter
Jan 16, 2023
7924fc9
Remove #process_commit_data default sha value
Jan 16, 2023
392cdf5
Remove #process_tag_data indent parameter
Jan 16, 2023
488afb8
Merge branch 'master' into sc-fix-gpgsig-parsing
jcouball Feb 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove #process_commit_data default sha value 
As with the previous commit, this default value was relevant when this
method was also used to process git log output. It no longer is, and its
only caller passes the sha value, so we can remove the default.

Signed-off-by: Simon Coffey <simon.coffey@futurelearn.com>
  • Loading branch information
Simon Coffey committed Jan 17, 2023
commit 7924fc9496241b27d08971a7de45d9880e89d56e
2 changes: 1 addition & 1 deletion lib/git/lib.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ def commit_data(sha)
process_commit_data(cdata, sha)
end

def process_commit_data(data, sha = nil)
def process_commit_data(data, sha)
hsh = {
'sha' => sha,
'parent' => []
Expand Down