Skip to content

grep: Allow the use of an array of path limiters and extended_regexp as an available option. #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2023

Conversation

blanham
Copy link
Contributor

@blanham blanham commented Feb 23, 2023

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Ensure all commits include DCO sign-off.
  • Ensure that your contributions pass unit testing.
  • Ensure that your contributions contain documentation if applicable.

Description

This PR addsextended_regexp as a passable option, and allows multiple path limiters to be used. I think the additions are fairly self-explanatory, but happy to answer questions if need be.

Signed-off-by: Bryce Lanham <blanham@gmail.com>
@blanham blanham changed the title Allow the use of an array of path limiters and extended_regexp as an available option. grep: Allow the use of an array of path limiters and extended_regexp as an available option. Feb 23, 2023
Signed-off-by: James Couball <jcouball@yahoo.com>
@jcouball jcouball force-pushed the add_git_grep_missing_features branch from 5d51ce6 to 60758f3 Compare February 24, 2023 00:12
Copy link
Member

@jcouball jcouball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I added documentation for Git::Base#grep including the additions introduced by this PR.

Thank you @blanham for the contribution!

@jcouball jcouball merged commit 0f7c4a5 into ruby-git:master Feb 24, 2023
@jcouball jcouball mentioned this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants